test cruise types #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Expand automated testing suite to test multiple cruise types instead of just "ar77". The changes parametrize existing test functions to iterate through five different cruise types: "ar77", "en617", "hrs2303", "ae2426", and "at46".
- Add cruise type arrays and expected data counts for each cruise
- Convert hardcoded single-cruise tests to parameterized multi-cruise tests
- Add wrapper functions to execute tests across all cruise types
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/underway.js | Parameterized underway data tests for multiple cruises with expected counts and time ranges |
| tests/nut.js | Added multi-cruise support for nutrient data testing |
| tests/niskin.js | Converted niskin bottle tests to run across all cruise types |
| tests/metadata.js | Parameterized metadata tests with cruise-specific expected line counts |
| tests/hplc.js | Added multi-cruise testing for HPLC data |
| tests/event.js | Expanded event testing to cover all cruise types with specific R2R event IDs |
| tests/chl.js | Parameterized chlorophyll data tests for multiple cruises |
| tests/cast.js | Added multi-cruise support for CTD cast operations and special handling for ae2426 |
| tests/bottle.js | Converted bottle data tests to support multiple cruise types |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add these cruise types to the Automated Testing suite:
cruises = ["ar77", "en617", "hrs2303", "ae2426", "at46"]